kie-issues#1276: Reuse components and retrieve workflow definitions from data index instead of openapi.json in sonataflow-deployment-webapp #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaradityaraj
changed the title
|
@fantonangeli please assign me this issue. |
fantonangeli
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Thanks a lot @kumaradityaraj
Besides the changes in this PR, I can see there are a few unused dependencies from the past:
- apollo-cache-inmemory
- apollo-client
- apollo-link-http
- util
- URL
Can you please check if they are really needed and in case remove them?
packages/sonataflow-deployment-webapp/src/pages/Workflows/Workflows.tsx
Outdated
Show resolved
Hide resolved
packages/sonataflow-deployment-webapp/src/navigation/RoutesSwitch.tsx
Outdated
Show resolved
Hide resolved
packages/sonataflow-deployment-webapp/src/navigation/RoutesSwitch.tsx
Outdated
Show resolved
Hide resolved
fantonangeli
requested changes
Aug 20, 2024
...ages/sonataflow-deployment-webapp/src/runtimeTools/pages/RuntimeToolsWorkflowDefinitions.tsx
Outdated
Show resolved
Hide resolved
...ages/sonataflow-deployment-webapp/src/runtimeTools/pages/RuntimeToolsWorkflowDefinitions.tsx
Outdated
Show resolved
Hide resolved
packages/sonataflow-deployment-webapp/src/pages/Workflows/Workflows.tsx
Outdated
Show resolved
Hide resolved
packages/sonataflow-deployment-webapp/src/pages/Workflows/Workflows.tsx
Outdated
Show resolved
Hide resolved
fantonangeli
requested changes
Aug 21, 2024
...ages/sonataflow-deployment-webapp/src/runtimeTools/pages/RuntimeToolsWorkflowDefinitions.tsx
Outdated
Show resolved
Hide resolved
fantonangeli
added
pr: waiting-for-review
fantonangeli
approved these changes
Aug 21, 2024
tiagobento
reviewed
Aug 26, 2024
Comment on lines
-44
to
-56
| "@patternfly/react-table": "^4.112.39", | ||
| "apollo-cache-inmemory": "1.6.6", | ||
| "apollo-client": "2.6.10", | ||
| "apollo-link-http": "1.5.17", | ||
| "openapi-types": "^7.0.1", | ||
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-router": "^5.3.4", | ||
| "react-router-dom": "^5.3.4", | ||
| "typescript": "^5.5.3", | ||
| "util": "^0.12.5" |
There was a problem hiding this comment.
Thank you for cleaning this up! 👍
|
@tiagobento can we consider your comment an approval? |
domhanak
approved these changes
Sep 6, 2024
tiagobento
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Good to go when conflicts are solved. @kumaradityaraj Please accept pnpm-lock.json from main then re-bootstrap the repo:
git fetch origingit merge origin/main--> Conflict will happen here.git checkout origin/main -- pnpm-lock.jsonpnpm bootstrapgit merge --continue
That's how I'm used to solving it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fantonangeli
Closes - apache/incubator-kie-issues-1276
Description :
Sonataflow-deployment-webapp used to render the list of workflow definitions using the openapi.json api. In the latest commit the workflow definition is now being rendered through the data-index using graphql service.
How to test :
pnpm startneeds to be executed from sonataflow-deployment-webapp.sonataflow-deployment-webapp-consumerneeds to be running in the background. Link of this repo - https://github.com/fantonangeli/sonataflow-deployment-webapp-consumerPreview :
Screen.Recording.2024-08-19.at.1.51.06.PM.1.1.mov