Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Update screenshots for failing tests #2555

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

danielzhe
Copy link
Contributor

@danielzhe danielzhe commented Sep 3, 2024

The test started to fail probably because of an update in Chrome that changed the behavior of the CSS since there was no PR with a failing test was merged.
Also, the others tests (Chromium and Webkit) didn't have any change.

@yesamer
Copy link
Contributor

yesamer commented Sep 4, 2024

@danielzhe It seems there's another screenshot to fix in Test Scenario Editor

@danielzhe
Copy link
Contributor Author

@danielzhe It seems there's another screenshot to fix in Test Scenario Editor

Updated! It's weird how they were not failing before. I expect that maybe more can fail.

Btw, I checked each one of the failing tests just to be sure that there was nothing broken and it are just small details in the render.

@tiagobento tiagobento changed the title NO-ISSUE: Update screenshot for failing test. NO-ISSUE: Update screenshot for failing tests Sep 4, 2024
@tiagobento tiagobento changed the title NO-ISSUE: Update screenshot for failing tests NO-ISSUE: Update screenshots for failing tests Sep 4, 2024
Copy link
Contributor

@kbowers-ibm kbowers-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting that out @danielzhe!

@kbowers-ibm kbowers-ibm merged commit 046dd3c into apache:main Sep 5, 2024
14 checks passed
danielzhe added a commit to danielzhe/kie-tools that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants