Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Use correct properties on jbpm-compact-architecture-example #2557

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

thiagoelg
Copy link
Member

  • Replace kogito.dataindex.http.url with kogito.data-index.url;
  • Add CORS properties (to support any host)

Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Great! I tested all setups (dev mode + prod mod) and works fine, looks like the kogito.dataindex.http.url is no longer needed in compact setup since the interactions will happen inside the VM :D

@@ -13,7 +15,7 @@ kogito.service.url=http://0.0.0.0:8080

#Job-service
kogito.jobs-service.url=http://0.0.0.0:8080
kogito.dataindex.http.url=http://0.0.0.0:8080
kogito.data-index.url=http://0.0.0.0:8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Looks like this prop (kogito.data-index.url) isn't needed in the compact setup for SVG addon since the communication between the data-index and the SVG addon works directly in VM via CDI .

Effectively, setting the kogito.data-index.url will prevent the Data Index Addon to auto generate this property.

@thiagoelg thiagoelg merged commit 242412c into apache:main Sep 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants