kie-issues#1281: The Timeline goes to the bottom with long endpoints in WorkflowInstance page #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fantonangeli Please review this PR. Thank you. |
|
@fantonangeli Can you please review this? Thanks! |
|
@tiagobento I think there is a layout issue with the |
|
@kumaradityaraj Your screenshot didn't finish uploading to the description... |
fantonangeli
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Tested on:
- serverless-logic-web-tools
- serverless-workflow-dev-ui-webapp
- sonataflow-deployment-webapp
- sonataflow-management-console
- jbpm-compact-architecture-example
- sonataflow-greeting-quarkus-example
LGTM. Please @kumaradityaraj update the video
thiagoelg
approved these changes
Oct 8, 2024
domhanak
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#1281
Description :
When a workflow instance was opened and the endpoint was too long then the timeline card moves below the details card because the full endpoint link was displayed. Now the truncated endpoint link is displayed.
How to test:
Open a workflow instance and try to change the endpoint url to a long string; it will display the truncated link.
Preview:
Screen.Recording.2024-09-27.at.12.02.32.PM.mov