-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Use image-builder
and maven-m2-repo-via-http-image
to build serverless-logic-web-tools-swf-dev-mode-image
#2574
Conversation
… serverless-logic-web-tools-swf-dev-mode-image
@fantonangeli can you help validate that the image still works as expected? |
I still have to read all the code. Are we supposed to wait the release to test this as it is under apache path? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagoelg @tiagobento
The image works well for me locally but when I try it in OpenShift I get this error.
Did you manage to test it in OpenShift?
[INFO] Invoking resources:3.3.1:resources (default-resources) @ serverless-logic-web-tools-swf-deployment-quarkus-app
[INFO] Copying 230 resources from src/main/resources to target/classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.729 s
[INFO] Finished at: 2024-09-12T08:07:12Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.8.6:dev (default-cli) on project serverless-logic-web-tools-swf-deployment-quarkus-app: copying /home/kogito/serverless-logic-web-tools-swf-deployment-quarkus-app/src/main/resources/application.properties to /home/kogito/serverless-logic-web-tools-swf-deployment-quarkus-app/target/classes/application.properties failed with FileSystemException: /home/kogito/serverless-logic-web-tools-swf-deployment-quarkus-app/target/classes/application.properties: Operation not permitted -> [Help 1]
@fantonangeli can you provide the steps to reproduce this? I think I know how to fix it, but I need to test. |
@thiagoelg pinged on Zulip |
@thiagoelg I'm sorry I still have this error, what am I missing?
|
@fantonangeli Your OCP cluster probably cached the previous version (to always pull the image, the Deployment needs to be configured with I've published the same image under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works well. Thanks @thiagoelg
This PR refactors the build process of the
serverless-logic-web-tools-swf-dev-mode-image
package to use ourimage-builder
andmaven-m2-repo-via-http-image
tools.With this change, the local m2 repository is served via a Docker container inside the same Docker network as the builder container, making it possible to fetch all locally built dependencies to Maven during build/install.
The dev-mode image now runs in offline mode, as the m2-repo container is unavailable during runtime. Still, all dependencies should already be available inside the container's filesystem (in /home/kogito/.m2/repository).
The
--ulimit nofile=5000:5000
flags from the Docker build command were removed asimage-builder
doesn't support passing flags to the Docker CLI for now. If the CI breaks, we can implement it.