kie-issues#2545: Create a landing page for the Jobs Service #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fantonangeli Please review this PR. Thank you. |
fantonangeli
requested changes
Sep 16, 2024
| </p> | ||
| <div> | ||
| <a | ||
| href="https://kiegroup.github.io/kogito-docs/serverlessworkflow/latest/job-services/core-concepts.html" |
There was a problem hiding this comment.
@wmedvede @ricardozanini
Which link should we add as documentation?
Is https://kiegroup.github.io/kogito-docs/serverlessworkflow/latest/job-services/core-concepts.html ok?
There was a problem hiding this comment.
Can we use an env var to set the link?
For Processes, we would probably use https://docs.kogito.kie.org/latest/html_single/#con-jobs-service_kogito-configuring instead.
There was a problem hiding this comment.
We can add both. jBPM the one @thiagoelg mentioned, and the SonataFlow one here: https://sonataflow.org/serverlessworkflow/main/job-services/core-concepts.html
ricardozanini
approved these changes
Sep 16, 2024
fantonangeli
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator/-kie-issues#2545
Description:
Its a landing page for jobs service. Earlier it only showed the error and there was not any friendly message for the user but now we have it. The page has two different views one for light mode and the other one for dark mode as shown below.
How to test
pnpm startPreview
Screen.Recording.2024-09-16.at.1.24.21.PM.mov