Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#2545: Create a landing page for the Jobs Service #2592

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

kumaradityaraj
Copy link
Contributor

Closes apache/incubator/-kie-issues#2545

Description:
Its a landing page for jobs service. Earlier it only showed the error and there was not any friendly message for the user but now we have it. The page has two different views one for light mode and the other one for dark mode as shown below.

How to test

  • go to packages/jobs-service-webapp
  • pnpm start

Preview

Screen.Recording.2024-09-16.at.1.24.21.PM.mov

@kumaradityaraj
Copy link
Contributor Author

@fantonangeli Please review this PR. Thank you.

packages/jobs-service-webapp/src/styles.css Outdated Show resolved Hide resolved
packages/jobs-service-webapp/src/index.html Outdated Show resolved Hide resolved
</p>
<div>
<a
href="https://kiegroup.github.io/kogito-docs/serverlessworkflow/latest/job-services/core-concepts.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an env var to set the link?

For Processes, we would probably use https://docs.kogito.kie.org/latest/html_single/#con-jobs-service_kogito-configuring instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add both. jBPM the one @thiagoelg mentioned, and the SonataFlow one here: https://sonataflow.org/serverlessworkflow/main/job-services/core-concepts.html

Copy link
Contributor

@fantonangeli fantonangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagobento tiagobento merged commit f2b4dff into apache:main Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a landing page for the Jobs Service
5 participants