kie-issues#2568: [sonataflow-management-console-webapp] Restyle 503 Keycloak page #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fantonangeli Please review this PR. Thank you. |
fantonangeli
requested changes
Sep 17, 2024
...e-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx
Outdated
Show resolved
Hide resolved
...e-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx
Outdated
Show resolved
Hide resolved
packages/runtime-tools-components/src/common/static/favicon.svg
Outdated
Show resolved
Hide resolved
|
Would it be possible to more or less follow what PatternFly itself suggests for error pages? Example: https://www.patternfly.org/2022.05/ux-writing/http-404-pages/ |
fantonangeli
requested changes
Sep 18, 2024
...e-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx
Outdated
Show resolved
Hide resolved
...e-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx
Outdated
Show resolved
Hide resolved
...e-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx
Outdated
Show resolved
Hide resolved
domhanak
approved these changes
Sep 19, 2024
fantonangeli
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator/kie-issues#2568
Description:
The KeyCloack page has been redesigned and the logo has also been changed; the UI looks smooth now.
How to test:
pnpm -r -F sonataflow-management-console-webapp... build:dev. run this command from the root folderSONATAFLOW_MANAGEMENT_CONSOLE_WEBAPP__sonataflowEnvMode=PROD pnpm start:dev-webapp. run this command after navigating to thepackage/sonataflow-management-console-webappPreview:
Updated Preview
