kie-issues#1376: The width information are not being deleted from DMN when the expression is deleted in the new Boxed Expression Editor #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom DMN when the expression is deleted in the new Boxed Expression Editor
danielzhe
commented
Sep 19, 2024
| @@ -89,7 +89,6 @@ export function BoxedExpressionScreen({ container }: { container: React.RefObjec | |||
| const dmnEditorStoreApi = useDmnEditorStoreApi(); | |||
|
|
|||
| const thisDmn = useDmnEditorStore((s) => s.dmn); | |||
| const diagram = useDmnEditorStore((s) => s.diagram); | |||
There was a problem hiding this comment.
Cleaning. This constant wast not being used.
danielzhe
commented
Sep 19, 2024
| @@ -30,20 +30,9 @@ export function updateExpressionWidths({ | |||
| drdIndex: number; | |||
| widthsById: Map<string, number[]>; | |||
| }): void { | |||
| const { widthsExtension, widths } = addOrGetDrd({ definitions, drdIndex }); | |||
| const componentWidthsMap = widths.reduce( | |||
There was a problem hiding this comment.
The issue was that we were always reloading all the widths from the definitions into the widthsById.
They are loaded the first time here:
And then the Boxed Expression Editor is who changes the widthsById.
The updateExpressionWidth should only update the definitions from widthsById, not fill the widthsById.
danielzhe
added
pr: waiting-for-review
|
|
jomarko
approved these changes
Sep 23, 2024
tiagobento
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1376