Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1158: On the Boxed Expression Component, changing the ExpressionVariableCell text content will fail to commit if the focus is changed to another cell #2611

Merged
merged 22 commits into from
Oct 7, 2024

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Sep 23, 2024

Closes: apache/incubator-kie-issues#1158

Screenshot 2024-09-25 090940

In the attached screenshot we can notice:

  • rectangle containing "edited name here", that has currently a focus, it is a html input element
  • dark blue rectangle wrapping this input, basically a table cell

The issue is about committing the "edited name here" text using mouse click. Currently user can commit changes by clicking:

  • outside whole "Invocation" expression, it means outside table
  • or somewhere in dark blue rectangle but outside "edited name here" rectangle

Otherwise, the onBlur handler of the "edited name here" is not invoked. So the current draft solution is to force blur event when some table cell is clicked.

…essionVariableCell text content will fail to commit if the focus is changed to another cell

Closes: apache/incubator-kie-issues#1158
@jomarko jomarko added pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development area:dmn labels Sep 23, 2024
@tiagobento
Copy link
Contributor

@jomarko Can you please explain this solution?

@jomarko jomarko marked this pull request as ready for review September 30, 2024 14:45
@jomarko jomarko removed pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Oct 1, 2024
@jomarko
Copy link
Contributor Author

jomarko commented Oct 1, 2024

I have removed the flags, as the PR is basically done, however screenshots comparison tests are failing due to the difference of the GitHub Ubuntu machine and my local Ubuntu machine. Figuring out how to generate proper screenshots.

@yesamer yesamer merged commit 62fbc0b into apache:main Oct 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants