-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1158: On the Boxed Expression Component, changing the ExpressionVariableCell text content will fail to commit if the focus is changed to another cell #2611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essionVariableCell text content will fail to commit if the focus is changed to another cell Closes: apache/incubator-kie-issues#1158
jomarko
added
pr: DO NOT MERGE
Draft PR, not ready for merging
pr: wip
PR is still under development
area:dmn
labels
Sep 23, 2024
@jomarko Can you please explain this solution? |
jomarko
removed
pr: DO NOT MERGE
Draft PR, not ready for merging
pr: wip
PR is still under development
labels
Oct 1, 2024
I have removed the flags, as the PR is basically done, however screenshots comparison tests are failing due to the difference of the GitHub Ubuntu machine and my local Ubuntu machine. Figuring out how to generate proper screenshots. |
tiagobento
approved these changes
Oct 1, 2024
kbowers-ibm
approved these changes
Oct 7, 2024
yesamer
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1158
In the attached screenshot we can notice:
input
elementinput
, basically a table cellThe issue is about committing the "edited name here" text using mouse click. Currently user can commit changes by clicking:
Otherwise, the
onBlur
handler of the "edited name here" is not invoked. So the current draft solution is to force blur event when some table cell is clicked.