Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.x] NO-ISSUE: Use maven-m2-repo-via-http to build sonataflow-builder/devmode-images #2616

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

thiagoelg
Copy link
Member

This change makes the images buildable when the dependencies are not yet published in a remote Maven repository (i.e. when building a pre-release from source).

Note: The images are still not buildable in macOS or Windows, but that can be fixed later.

@thiagoelg thiagoelg changed the title NO-ISSUE: Use maven-m2-repo-via-http to build sonataflow-builder/devmode-images [10.0.x] NO-ISSUE: Use maven-m2-repo-via-http to build sonataflow-builder/devmode-images Sep 24, 2024
Copy link
Contributor

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

thank you @thiagoelg for unblocking the release :)

@tiagobento
Copy link
Contributor

tiagobento commented Sep 24, 2024

After this PR [1] is merged inmain, we need to forward-port these fixes to main as well.

@thiagoelg
Copy link
Member Author

PR for main: #2617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants