Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix tests and test command of sonataflow-image-common #2629

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,25 @@ runs:
gir1.2-appindicator3-0.1
fi

- name: "Setup xmllint (Ubuntu Only)"
shell: bash
run: |
echo "STEP: Setup xmllint library (Ubuntu Only)"
cd ${{ inputs.working_dir }}
if [ "${{ runner.os }}" == "Linux" ]; then
sudo apt-get install -y \
libxml2-utils > /dev/null 2>&1
fi

- name: "Update bash for macOS (macOS Only)"
shell: bash
if: runner.os == 'macOS'
run: |
echo "STEP: Update bash for macOS (macOS Only)"
brew update
brew install bash
echo "/usr/local/bin" >> $GITHUB_PATH

- name: "Print storage usage (after setup)"
shell: bash
run: |
Expand Down
4 changes: 3 additions & 1 deletion .github/supporting-files/ci/partitions/partition1.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ chrome-extension-serverless-workflow-editor
vscode-extension-dashbuilder-editor
yard-vscode-extension
swf-vscode-extension
@kie-tools/sonataflow-management-console-image
@kie-tools/sonataflow-management-console-image
@kie/kogito-jit-runner-image
@kie/kogito-jobs-service-allinone-image
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ To build and test all packages of the Apache KIE Tools project, you're going to
- Python `3.12` _(To install, follow these instructions: https://www.python.org/downloads/)_
- Helm `3.13.3` _(To install, follow these instructions: https://helm.sh/docs/intro/install/)_
- Make
- xmllint _(To install, follow these instructions: https://www.baeldung.com/linux/xmllint)_
- bash `5.x` _(On Linux or Nix you should be fine. On macOS, follow these instructions to use zsh: https://support.apple.com/102360)_

> **ℹ️ NOTE**
>
Expand Down
3 changes: 2 additions & 1 deletion devbox.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"kubernetes-helm": "3.13.3",
"gnumake": "4.4.1",
"go": "1.21.9",
"python": "3.12.2"
"python": "3.12.2",
"libxml2": "2.13.3"
},
"env": {
"PLAYWRIGHT_BROWSERS_PATH": "0",
Expand Down
104 changes: 104 additions & 0 deletions devbox.lock
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,110 @@
}
}
},
"[email protected]": {
"last_modified": "2024-09-12T11:58:09Z",
"resolved": "github:NixOS/nixpkgs/280db3decab4cbeb22a4599bd472229ab74d25e1#libxml2",
"source": "devbox-search",
"version": "2.13.3",
"systems": {
"aarch64-darwin": {
"outputs": [
{
"name": "bin",
"path": "/nix/store/7gi1kd2mz9jc8ya4lkqhlv9vklc5qr2j-libxml2-2.13.3-bin",
"default": true
},
{
"name": "dev",
"path": "/nix/store/mnij865rdzrrnxqmhj4s0abmd1xx771v-libxml2-2.13.3-dev"
},
{
"name": "devdoc",
"path": "/nix/store/80bkizndgvrqiq42ig681irxswsf4kxv-libxml2-2.13.3-devdoc"
},
{
"name": "out",
"path": "/nix/store/sr8lnkgivqcd06113nsk5p3jz2xcx7rp-libxml2-2.13.3"
}
],
"store_path": "/nix/store/7gi1kd2mz9jc8ya4lkqhlv9vklc5qr2j-libxml2-2.13.3-bin"
},
"aarch64-linux": {
"outputs": [
{
"name": "bin",
"path": "/nix/store/gxpp5r2nbs3s0n5rw0jbnm1k5lhxrx13-libxml2-2.13.3-bin",
"default": true
},
{
"name": "devdoc",
"path": "/nix/store/0qnymx6l3c7998yscwvr1q64iz447hfc-libxml2-2.13.3-devdoc"
},
{
"name": "out",
"path": "/nix/store/da857dg9ip02lkci5nicgvkzf419jzc7-libxml2-2.13.3"
},
{
"name": "py",
"path": "/nix/store/qfpnqradhvhicl1hm70w7891bk95lkad-libxml2-2.13.3-py"
},
{
"name": "dev",
"path": "/nix/store/dph7mh2dhl8sl4i44wlgnmsrwdlcv0bc-libxml2-2.13.3-dev"
}
],
"store_path": "/nix/store/gxpp5r2nbs3s0n5rw0jbnm1k5lhxrx13-libxml2-2.13.3-bin"
},
"x86_64-darwin": {
"outputs": [
{
"name": "bin",
"path": "/nix/store/gg4x2l8wy3lkd94bxpl0z7gnn9pa365i-libxml2-2.13.3-bin",
"default": true
},
{
"name": "dev",
"path": "/nix/store/pzakdvnmm99gic3mqyg8375b08dvkqxm-libxml2-2.13.3-dev"
},
{
"name": "devdoc",
"path": "/nix/store/xa27lhlrc2ya3i67g7nz53g64l3wqvjw-libxml2-2.13.3-devdoc"
},
{
"name": "out",
"path": "/nix/store/ac73mddfvraxgvd816r9h57df35mm6gd-libxml2-2.13.3"
}
],
"store_path": "/nix/store/gg4x2l8wy3lkd94bxpl0z7gnn9pa365i-libxml2-2.13.3-bin"
},
"x86_64-linux": {
"outputs": [
{
"name": "bin",
"path": "/nix/store/2y4a178s4w60v4m8749xhaawf8ga7cw5-libxml2-2.13.3-bin",
"default": true
},
{
"name": "dev",
"path": "/nix/store/v40g7q9zix1ycpyara08brd50m00471n-libxml2-2.13.3-dev"
},
{
"name": "devdoc",
"path": "/nix/store/cs49b70qkgygx0wxcl04dpy1d1g5vb91-libxml2-2.13.3-devdoc"
},
{
"name": "out",
"path": "/nix/store/nr8mh99sfsb1gw1b1qmrwhzmxbhj84j7-libxml2-2.13.3"
},
{
"name": "py",
"path": "/nix/store/p17nrcsmvb0q7b9g6347imljapbfcsb1-libxml2-2.13.3-py"
}
],
"store_path": "/nix/store/2y4a178s4w60v4m8749xhaawf8ga7cw5-libxml2-2.13.3-bin"
}
}
},
"[email protected]": {
"last_modified": "2024-03-22T11:26:23Z",
"resolved": "github:NixOS/nixpkgs/a3ed7406349a9335cb4c2a71369b697cecd9d351#maven",
Expand Down
4 changes: 2 additions & 2 deletions packages/sonataflow-image-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
"url": "https://github.com/apache/incubator-kie-tools/issues"
},
"scripts": {
"build:prod": "run-script-if --bool \"$(build-env tests.run)\" --then \"pnpm test\"",
"build:prod": "pnpm test",
"install": "node install.js",
"test": "run-script-os",
"test:linux:darwin": "mkdir -p dist-tests && rm -rf dist-tests/* && make -C ./resources bats || $(build-env tests.ignoreFailures) && mv dist-tests/report.xml dist-tests/junit-report.xml || true",
"test:linux:darwin": "run-script-if --ignore-errors \"$(build-env tests.ignoreFailures)\" --bool \"$(build-env tests.run)\" --then \"mkdir -p dist-tests\" \"rm -rf dist-tests/*\" \"make -C ./resources bats\" --finally \"touch dist-tests/report.xml\" \"mv dist-tests/report.xml dist-tests/junit-report.xml\"",
"test:win32": "echo \"Tests are skipped in Windows\""
},
"devDependencies": {
Expand Down
Loading
Loading