Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Add license header #2655

Closed
wants to merge 5 commits into from
Closed

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Oct 10, 2024

No description provided.

* under the License.
*/


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why after "package" ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko This is a copied file from javax.annotation module.... not sure we can mark it with our package, please double check

@jomarko
Copy link
Contributor Author

jomarko commented Oct 11, 2024

@yesamer hi, thank you for comments. In this message, lets discuss Why after "package".

I used https://creadur.apache.org/rat017/apache-rat/ tool for adding the headers, especially the --edit-license option. I and @jstastny-cz used this tool for licenses presence verification, so I thought using it for license addition will be not problematic.

I see your point, that it is not consistent with the rest of similar files. Now it is question, if we have other automatic way of adding headers that would be:

  • compatible with the kie build
  • compatible with the existing headers placement
  • compatible with the apache-rat automatic checks or if we have other tool for apache licenses header checks

Situation is even more complicated, for some yaml files related to helm-chart that I thought they need to license, running pnpm format will remove headers from them.

@yesamer
Copy link
Contributor

yesamer commented Oct 14, 2024

@jomarko Thank you for the explanation. It makes sense, and ultimately those Java files are part of the old editors... which should be dismissed in the future. I still believe that the Generated class shouldn't be marked with the Apache header, as copied from javax package.

@jomarko
Copy link
Contributor Author

jomarko commented Nov 14, 2024

This will be addressed via apache/incubator-kie-issues#1613

@jomarko jomarko closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants