-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Add license header #2655
Conversation
This reverts commit 8ec1d38.
...pmn/client/marshall/converters/tostunner/properties/util/CorrelationPropertyReaderUtils.java
Show resolved
Hide resolved
...stunner/bpmn/client/marshall/converters/tostunner/properties/util/CorrelationReaderData.java
Show resolved
Hide resolved
* under the License. | ||
*/ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why after "package" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jomarko This is a copied file from javax.annotation module.... not sure we can mark it with our package, please double check
.../stunner-editors/errai-common/src/main/java/org/jboss/errai/common/client/util/TimeUnit.java
Show resolved
Hide resolved
@yesamer hi, thank you for comments. In this message, lets discuss I used https://creadur.apache.org/rat017/apache-rat/ tool for adding the headers, especially the I see your point, that it is not consistent with the rest of similar files. Now it is question, if we have other automatic way of adding headers that would be:
Situation is even more complicated, for some yaml files related to helm-chart that I thought they need to license, running |
@jomarko Thank you for the explanation. It makes sense, and ultimately those Java files are part of the old editors... which should be dismissed in the future. I still believe that the Generated class shouldn't be marked with the Apache header, as copied from javax package. |
This will be addressed via apache/incubator-kie-issues#1613 |
No description provided.