apache/incubator-kie-issues#1594: Security fixes for blank-app container #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcelli
requested review from
thiagoelg and
tiagobento
and removed request for
tiagobento
tiagobento
reviewed
Oct 30, 2024
Comment on lines
+95
to
+104
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java</artifactId> | ||
| <version>${version.com.google.protobuf}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java-util</artifactId> | ||
| <version>${version.com.google.protobuf}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Can you please add a comment here with a disclaimer that those dependencies are only here to force this application to use a newer version of these dependencies? This will help not having people thinking this is necessary for the app to function properly.
tiagobento
approved these changes
Oct 30, 2024
ricardozanini
pushed a commit
to ricardozanini/kogito-tooling
that referenced
this pull request
Nov 5, 2024
…nk-app (apache#2716) Co-authored-by: Tiago Bento <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#1594