Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Upgrade [email protected] to 1.9.0 #2717

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

tiagobento
Copy link
Contributor

@tiagobento tiagobento commented Oct 30, 2024

The strategy here was to manually remove the [email protected] entry from the lockfile and run pnpm install --fix-lockfile.

@tiagobento tiagobento added the area:dependencies Pull requests that update a dependency file label Oct 30, 2024
Copy link
Member

@thiagoelg thiagoelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the deprecated notices, but other than that this looks good to me!

Good to see that the new logic for checking changes to the lockfile is working, even though it didn't help that much in this case.

@@ -14371,196 +14286,168 @@ packages:
'@babel/[email protected]':
resolution: {integrity: sha512-71YHIvMuiuqWJQkebWJtdhQTfd4Q4mF76q2IX37uZPkG9+olBxsX+rH1vkhFto4UeJZ9dPY2s+mDvhDm1u2BGQ==}
engines: {node: '>=6.9.0'}
deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never knew we had these deprecated notices here... and so many of them!
Maybe we should keep them and plan to tackle them soon.

I'm assuming most of these deprecated packages are transitive dependencies, but some of them (like q) are really old!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.... I think dependabot added those when it updated express, I'm guessing those are from a newer version of pnpm? Need to investigate.

@tiagobento tiagobento merged commit 7bbb481 into apache:main Oct 31, 2024
14 checks passed
ricardozanini pushed a commit to ricardozanini/kogito-tooling that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants