-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Upgrade [email protected]
to 1.9.0
#2717
Conversation
9951d55
to
3edbe42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment about the deprecated
notices, but other than that this looks good to me!
Good to see that the new logic for checking changes to the lockfile is working, even though it didn't help that much in this case.
@@ -14371,196 +14286,168 @@ packages: | |||
'@babel/[email protected]': | |||
resolution: {integrity: sha512-71YHIvMuiuqWJQkebWJtdhQTfd4Q4mF76q2IX37uZPkG9+olBxsX+rH1vkhFto4UeJZ9dPY2s+mDvhDm1u2BGQ==} | |||
engines: {node: '>=6.9.0'} | |||
deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never knew we had these deprecated
notices here... and so many of them!
Maybe we should keep them and plan to tackle them soon.
I'm assuming most of these deprecated packages are transitive dependencies, but some of them (like q) are really old!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.... I think dependabot added those when it updated express, I'm guessing those are from a newer version of pnpm? Need to investigate.
The strategy here was to manually remove the
[email protected]
entry from the lockfile and runpnpm install --fix-lockfile
.