kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name #2760
Conversation
…update all references to the old name
…update all references to the old name
danielzhe
force-pushed
the
rename-variables-9.2
branch
from
f04b142
to
de7015e
Compare
danielzhe
changed the title
|
|
||
| const resetFormData = useCallback(() => { | ||
| setExpressionName(selectedExpressionName); | ||
| setDataType(selectedDataType); | ||
| }, [selectedExpressionName, selectedDataType]); | ||
|
|
||
| // onCancel doens't prevent the onHide call | ||
| // onCancel doesn't prevent the onHide call |
|
Thank you for the PR @danielzhe. It's going to take me a few days to go over everything with the care it deserves. Will keep you posted! |
|
@danielzhe Storybook is pointing to code using |
01
|
02The feature seems to not work in decision tables. I think that at least the row 2 should be updated. I slightly think also decision table header row should be, however that may be very tricky and if we decide to implement, maybe in a separate ticket? I am not sure about the second point. The same seems to be reproducible if the user is renaming for example the |
03FYI, I didn't check this feature with the List expression because of apache/incubator-kie-issues#1635 |
04Question, should this feature work for BKM node and Invocation expression. Imagine this model: However if user renames the |
05We have an issue editor allows to define two function parameters with the same name, then renaming does not work. |
06Is there a way to disable this feature? Committing the rename action starts to be slower, so I expect some user may ask to disable this feature in their environment. |
07During included models review, I found this apache/incubator-kie-issues#1636, however I think I didn't find issue related to changes of #2760. |
- Fixes includes to point to src - Some refactor to reduce nesting
Closes: apache/incubator-kie-issues#208
Some comments about the changes:
Action.VariableChanged;Renaming Data Types
Data.Types.mp4
Renaming BKMs and parameters
Bkm.and.Parameters.mp4
General rename
Some.Renames.mp4
Renaming Included Models name
It does not show the confirmation dialog, because doesn't make sense to not update the references in this case, since this already was the default behavior before this PR (when we renamed a included model, we already updated all the references except the expressions, now we update the expressions).
Included.Models.mp4