fix(admin-cli): fix the command reports incorrect ERR_INVALID_PARAMETERS error #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GehaFearless
approved these changes
Nov 29, 2023
empiredan
approved these changes
Nov 29, 2023
GehaFearless
pushed a commit
to GehaFearless/incubator-pegasus
that referenced
this pull request
Feb 28, 2024
…ERS error (apache#1699) apache#1698 Do not set the `backupPath` field of `StartBackupAppRequest` if it's not set to avoid an `ERR_INVALID_PARAMETERS` error from server. The error is caused by a conflict check on server side between `StartBackupAppRequest.backupPath` and `[block_service.hdfs_service].{args}`, the latter has defined a default backup path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1698
Do not set the
backupPathfield ofStartBackupAppRequestif it's not setto avoid an
ERR_INVALID_PARAMETERSerror from server. The error is causedby a conflict check on server side between
StartBackupAppRequest.backupPathand
[block_service.hdfs_service].{args}, the latter has defined a defaultbackup path.