Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): Introduce spdlog to thirdparty #2084

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Jul 31, 2024

This is a previous work of #2083.

This patch introduces spdlog as a thirdparty
to prepare the docker image, then the #2083 can use it to run CI.

spdlog is a very fast C++ logging library, you can see the benchmarks:
https://github.com/gabime/spdlog?tab=readme-ov-file#benchmarks. spdlog using
libfmt to format message content, it is fast and compatible with the current
logging practice in Pegasus. It's a good choice to replace the current
simple_logger or screen_logger implementation in Pegasus.

@empiredan empiredan merged commit 097068d into apache:master Aug 1, 2024
66 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants