Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement consul discovery module & fix some typos #624

Closed
wants to merge 10 commits into from
Closed

feat: implement consul discovery module & fix some typos #624

wants to merge 10 commits into from

Conversation

CocaineCong
Copy link

@CocaineCong CocaineCong commented Dec 3, 2023

What this PR does:

add consul discovery module

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


what is change as following:

1. fix some typos:

eg :
serialzer-->serializerType EexpireTime -->ExpireTime

2. add judge in map

eg:

serializer, ok := undoLogContext[serializerKey]
if !ok {
    return
}

3. implement consul discovery

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the coding label Dec 3, 2023
@CocaineCong CocaineCong changed the title feat: implement consul discovery module feat: implement consul discovery module & fix some typos Dec 3, 2023
pkg/discovery/config.go Outdated Show resolved Hide resolved
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the version of hashicorp BSL license change, which is not compatible with the Apache license.

@CocaineCong
Copy link
Author

Note the version of hashicorp BSL license change, which is not compatible with the Apache license.

got it, sorry for my mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants