fix: apache/incubator-seata#6678 #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luky116
reviewed
Dec 7, 2024
| @@ -92,8 +93,9 @@ func (c *BaseTableMetaCache) refresh(ctx context.Context) { | |||
|
|
|||
| for i := range v { | |||
| tm := v[i] | |||
Code-Fight
requested changes
Dec 14, 2024
| @@ -92,8 +93,9 @@ func (c *BaseTableMetaCache) refresh(ctx context.Context) { | |||
|
|
|||
| for i := range v { | |||
| tm := v[i] | |||
| if _, ok := c.cache[tm.TableName]; !ok { | |||
| c.cache[tm.TableName] = &entry{ | |||
| var upperTableName = strings.ToUpper(tm.TableName) | |||
There was a problem hiding this comment.
这个ToUpper仅在refresh的加不行，需要在GetTableMeta的时，保证都是一致的
added 2 commits
December 25, 2024 23:00
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Convert table names to uppercase in cache, preventing different tables from being found
Which issue(s) this PR fixes:
Fixes #711
Special notes for your reviewer:
Does this PR introduce a user-facing change?: