feat: Implement automatic refresh functionality for TableMetaCache #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code-Fight
force-pushed
the
feature_refresh_cache
branch
from
830d64e to
d602569
Compare
luky116
reviewed
Dec 21, 2024
| @@ -92,7 +110,7 @@ func (c *BaseTableMetaCache) refresh(ctx context.Context) { | |||
|
|
|||
| for i := range v { | |||
| tm := v[i] | |||
| if _, ok := c.cache[tm.TableName]; !ok { | |||
| if _, ok := c.cache[tm.TableName]; ok { | |||
There was a problem hiding this comment.
这里是不是都得去刷新，而不用去判断原来是否存在？
我看java的实现也是先判断有没有，然后再去更新有的
如果直接更新也行，不过也要判断，要加个初始化
|
luky116
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement automatic refresh functionality for TableMetaCache
Which issue(s) this PR fixes:
Fixes #720
Special notes for your reviewer:
Does this PR introduce a user-facing change?: