Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor getty module #746

Merged
merged 26 commits into from
Dec 21, 2024
Merged

refactor getty module #746

merged 26 commits into from
Dec 21, 2024

Conversation

No-SilverBullet
Copy link
Contributor

What this PR does:
Refactoring the getty module:

  1. The logic of newSession is adjusted to sessionManager, all the logic of rpcClient is moved to sessionManager, and rpcClient is removed;
  2. The sessionManager member in gettyClientHandler is removed
  3. gettyRemoting cancels the singleton, as a member variable of gettyRemotingClient, gettyRemotingClient continues to maintain the singleton to provide communication capabilities for the upper layer
  4. Added the function of removing the session after the heartbeat fails and the maximum number of retries is exceeded

Which issue(s) this PR fixes:
#695
#694
#740

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

No-SilverBullet and others added 26 commits November 10, 2024 13:06
@No-SilverBullet
feat:add more linter
d84f3c0
@No-SilverBullet
Merge pull request #1 from No-SilverBullet/feat/add_linter
aaae50c 
feat:add more linter
@No-SilverBullet
feat:change golangclilint version to 1.57.x to support more linter
0fc667d
@No-SilverBullet
Merge pull request #2 from No-SilverBullet/feat/add_linter
6a4bebe 
feat:change golangclilint version to 1.57.x to support more linter
@No-SilverBullet
feat:adjust lint conf and adjust the code to pass the check
358f4ac
@No-SilverBullet
Merge pull request #3 from No-SilverBullet/feat/add_linter
ac85f94 
feat:adjust lint conf and adjust the code to pass the check
@luky116
Merge branch 'master' into master
5c23b6c
@luky116
Merge branch 'master' into master
fd25729
@luky116
Merge branch 'master' into master
202cd26
@No-SilverBullet
Merge branch 'apache:master' into master
eb16366
@No-SilverBullet
style: format some code; fix: some sql statement or rows was not been…
f20acfe 
… closed
@No-SilverBullet
feat:close session when send heart beat message failed
ce334f7
@No-SilverBullet
Merge pull request #4 from No-SilverBullet/feat/check_session_alive
758a214 
feat:close session when send heart beat message failed
@No-SilverBullet
Merge pull request #5 from No-SilverBullet/refactor/format
5add578 
style: format some code; fix: some sql statement or rows was not been…
@No-SilverBullet
Merge branch 'apache:master' into master
00bce0b
@solisamicus
refactor: change GettyRemoting from singleton to GettyRemotingClient …
5f2e225 
…member
@marsevilspirit
remove rpc client
10bf844
@marsevilspirit
Merge branch 'master' into refactor/getty
b92d5bf
@solisamicus
refactor: complete GettyRemoting refactoring
a4a789f
@solisamicus
refactor: change getter name, improve variable naming and remove unus…
265e45e 
…ed fields
@marsevilspirit
update something
b54d4b7
@No-SilverBullet
Merge pull request #9 from marsevilspirit/refactor/getty
f5f72b6 
update session manager
@No-SilverBullet
feat:add heart-beat failed retry times
a4caadb
@No-SilverBullet
Merge pull request #8 from No-SilverBullet/refactor/getty
dd541f8 
refactor/getty
@No-SilverBullet
Refactor getty.
001e49c 
>
>
Co-authored-by: marsevilspirit <[email protected]>
Co-authored-by: solisamicus <[email protected]>
Co-authored-by: No-SilverBullet  <[email protected]>
@No-SilverBullet @marsevilspirit @solisamicus
Refactor getty.
51d1cae 
Co-authored-by: marsevilspirit <[email protected]>
Co-authored-by: solisamicus <[email protected]>
Co-authored-by: No-SilverBullet  <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.7% Duplication on New Code

See analysis details on SonarQube Cloud

@luky116 luky116 merged commit 8ce1006 into apache:master Dec 21, 2024
7 checks passed
@Code-Fight Code-Fight mentioned this pull request Dec 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luky116 luky116 luky116 approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
coding remoting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@No-SilverBullet @AlexStocks @luky116 @solisamicus @marsevilspirit