bugfix: support jdk9+ compile code #4410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4410 +/- ##
=============================================
- Coverage 48.86% 48.84% -0.03%
- Complexity 4182 4183 +1
=============================================
Files 793 794 +1
Lines 28039 28054 +15
Branches 3426 3426
=============================================
+ Hits 13701 13702 +1
- Misses 12901 12911 +10
- Partials 1437 1441 +4
|
slievrly
reviewed
Feb 27, 2022
包装类改动的代码范围会比较广，工具类相对比较通用 |
|
|
| * @param buffer byteBuffer | ||
| */ | ||
| public static void flip(Buffer buffer) { | ||
| buffer.flip(); |
There was a problem hiding this comment.
返回类型，是不是应该return一下？没准其他哪里会用到。
下面的方法也看一下吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
使用jdk9及以上版本编译seata源码后在jdk8中进行引入,再默认序列化下,会出现
java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer)
需要将ByteBuffer转换为Buffer再调用相关函数
Ⅱ. Does this pull request fix one issue?
fixes #1410 #2223
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews