-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the column TINYINT(1)
in MySql being resolved to BIT
type
#6070
Open
wangliang181230
wants to merge
17
commits into
apache:2.x
Choose a base branch
from
wangliang181230:bugfix-tinyint1-2.x
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6070 +/- ##
=========================================
Coverage 49.29% 49.29%
- Complexity 4800 4803 +3
=========================================
Files 913 915 +2
Lines 31677 31727 +50
Branches 3825 3831 +6
=========================================
+ Hits 15614 15641 +27
- Misses 14514 14532 +18
- Partials 1549 1554 +5
|
slievrly
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license issue
This reverts commit 8f56510.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix: fix the column
TINYINT(1)
in MySql being resolved toBIT
type.修复 “MySql中的
TINYINT(1)
类型字段被解析为BIT
,导致回滚后的值要么是0,要么是1。而不是原来的值。” 的问题。Ⅱ. Does this pull request fix one issue?
fixes #6064
fixes #4006
fixes #1964
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews