optimize: support Nacos ram role authentication #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6148 +/- ##
============================================
+ Coverage 48.94% 49.05% +0.10%
- Complexity 4775 4793 +18
============================================
Files 913 913
Lines 31710 31737 +27
Branches 3827 3831 +4
============================================
+ Hits 15521 15567 +46
+ Misses 14653 14626 -27
- Partials 1536 1544 +8
|
funky-eyes
reviewed
Dec 21, 2023
There was a problem hiding this comment.
https://github.com/apache/incubator-seata/tree/2.x/script/client
客户端是否应该补充配置示例？
Should the client side supplement the configuration examples?
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
…13_04 # Conflicts: # changes/en-us/2.x.md
thanks for review, I have fixed it. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6148 +/- ##
============================================
- Coverage 49.06% 48.97% -0.10%
+ Complexity 4785 4779 -6
============================================
Files 915 915
Lines 31863 31890 +27
Branches 3849 3853 +4
============================================
- Hits 15635 15617 -18
- Misses 14676 14706 +30
- Partials 1552 1567 +15
|
funky-eyes
added
module/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support Nacos ram role authentication
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews