Test: increase common module unit test coverage #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6157 +/- ##
============================================
+ Coverage 48.94% 49.04% +0.09%
- Complexity 4775 4793 +18
============================================
Files 913 913
Lines 31710 31697 -13
Branches 3827 3823 -4
============================================
+ Hits 15521 15546 +25
+ Misses 14653 14620 -33
+ Partials 1536 1531 -5 |
l81893521
force-pushed
the
test_incr_common_unit_test
branch
from
6aa6296 to
f3669b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6157 +/- ##
============================================
+ Coverage 48.98% 49.73% +0.75%
- Complexity 4779 4880 +101
============================================
Files 915 915
Lines 31896 31880 -16
Branches 3855 3853 -2
============================================
+ Hits 15624 15857 +233
+ Misses 14710 14467 -243
+ Partials 1562 1556 -6
|
l81893521
force-pushed
the
test_incr_common_unit_test
branch
from
a651cd6 to
13e1ac5
Compare
l81893521
changed the title
lightClouds917
requested changes
Dec 25, 2023
common/src/test/java/io/seata/common/exception/AuthenticationFailedExceptionTest.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Dec 25, 2023
common/src/test/java/io/seata/common/exception/AuthenticationFailedExceptionTest.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Dec 25, 2023
common/src/test/java/io/seata/common/exception/JsonParseExceptionTest.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Dec 25, 2023
common/src/test/java/io/seata/common/exception/RedisExceptionTest.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Dec 25, 2023
common/src/test/java/io/seata/common/exception/RetryableExceptionTest.java
Outdated
Show resolved
Hide resolved
xingfudeshi
previously approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Please remove @Date @description @author .
I'm ok with other changes.
l81893521
force-pushed
the
test_incr_common_unit_test
branch
from
0433889 to
456415d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The coverage please see https://app.codecov.io/gh/apache/incubator-seata/pull/6157/tree
Ⅱ. Does this pull request fix one issue?
#6158
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews