Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize Hessian Serialize #6254

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize Hessian Serialize

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added the Do Not Merge Do not merge into develop label Jan 11, 2024
funky-eyes
funky-eyes previously approved these changes Jan 11, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to understand in more detail how this pr optimization point for security is done?

@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee6f660) 52.07% compared to head (6bcf556) 50.48%.

❗ Current head 6bcf556 differs from pull request most recent head a4c2883. Consider uploading reports for the commit a4c2883 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6254      +/-   ##
============================================
- Coverage     52.07%   50.48%   -1.60%     
+ Complexity     5199     5042     -157     
============================================
  Files           921      917       -4     
  Lines         32140    32010     -130     
  Branches       3869     3862       -7     
============================================
- Hits          16737    16159     -578     
- Misses        13779    14293     +514     
+ Partials       1624     1558      -66     
Files Coverage Δ
...ta/core/serializer/SerializerSecurityRegistry.java 54.44% <100.00%> (ø)
...io/seata/serializer/hessian/HessianSerializer.java 82.60% <100.00%> (ø)

... and 1834 files with indirect coverage changes

@slievrly slievrly removed the Do Not Merge Do not merge into develop label Feb 2, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 736f2b9 into apache:2.x Feb 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants