Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: upgrade spring mvc and tomcat.embed #6339

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Feb 6, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

upgrade spring mvc and tomcat.embed

Ⅱ. Does this pull request fix one issue?

tomcat:
MPS-uy56-j8e4
MPS-b5of-dwyh
MPS-hz9y-jtfe
MPS-67md-8wr2

spring mvc:
MPS-2022-62832

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added this to the 2.1.0 milestone Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65610d0) 51.94% compared to head (5f99661) 51.93%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6339      +/-   ##
============================================
- Coverage     51.94%   51.93%   -0.02%     
+ Complexity     5186     5184       -2     
============================================
  Files           921      921              
  Lines         32166    32166              
  Branches       3874     3874              
============================================
- Hits          16710    16705       -5     
- Misses        13821    13824       +3     
- Partials       1635     1637       +2     

see 3 files with indirect coverage changes

Copy link
Contributor

@liuqiufeng liuqiufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liuqiufeng liuqiufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 10bcd0f into apache:2.x Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants