-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: compatible with tcc #6345
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6345 +/- ##
============================================
+ Coverage 51.04% 51.06% +0.01%
- Complexity 5262 5264 +2
============================================
Files 934 934
Lines 33029 33029
Branches 4002 4002
============================================
+ Hits 16860 16865 +5
+ Misses 14503 14498 -5
Partials 1666 1666
|
@xingfudeshi some conflicts should be resolve. |
Ok |
…Compatible_with_tcc # Conflicts: # compatible/pom.xml # compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionContextUtil.java # compatible/src/main/java/io/seata/rm/tcc/api/BusinessActionContext.java # compatible/src/main/java/io/seata/rm/tcc/api/BusinessActionContextParameter.java
@slievrly Done. |
compatible/src/main/java/io/seata/rm/tcc/remoting/parser/LocalTCCRemotingParser.java
Outdated
Show resolved
Hide resolved
compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionContextUtil.java
Outdated
Show resolved
Hide resolved
compatible/src/main/java/io/seata/rm/tcc/interceptor/TccActionInterceptorHandler.java
Show resolved
Hide resolved
compatible/src/main/java/io/seata/rm/tcc/interceptor/parser/TccActionInterceptorParser.java
Outdated
Show resolved
Hide resolved
compatible/src/main/java/io/seata/rm/tcc/resource/parser/TccRegisterResourceParser.java
Outdated
Show resolved
Hide resolved
compatible/src/main/java/io/seata/spring/tcc/TccAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
|
||
import static org.apache.seata.common.Constants.BEAN_NAME_SPRING_FENCE_CONFIG; | ||
|
||
public class TccActionInterceptorHandler extends org.apache.seata.rm.tcc.interceptor.TccActionInterceptorHandler { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the api the user is using
这不是用户所使用的api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class handles annotations that start with io.seata. The annotation itself is just metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6344
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews