-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: use curator instead of zkclient in config model #6779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project seata-config-zk: Compilation failure: Compilation failure:
Error: /home/runner/work/incubator-seata/incubator-seata/config/seata-config-zk/src/test/java/org/apache/seata/config/zk/ZkConfigurationTest.java:[21,31] package org.apache.curator.test does not exist
Error: /home/runner/work/incubator-seata/incubator-seata/config/seata-config-zk/src/test/java/org/apache/seata/config/zk/ZkConfigurationTest.java:[35,22] cannot find symbol
Error: symbol: class TestingServer
Error: location: class org.apache.seata.config.zk.ZkConfigurationTest
Error: /home/runner/work/incubator-seata/incubator-seata/config/seata-config-zk/src/test/java/org/apache/seata/config/zk/ZkConfigurationTest.java:[41,22] cannot find symbol
Error: symbol: class TestingServer
Error: location: class org.apache.seata.config.zk.ZkConfigurationTest
Error: -> [Help 1]
…feat/curator_config_zk
…feat/curator_config_zk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6779 +/- ##
============================================
- Coverage 52.38% 52.30% -0.09%
- Complexity 6384 6407 +23
============================================
Files 1081 1083 +2
Lines 37617 37848 +231
Branches 4464 4493 +29
============================================
+ Hits 19706 19796 +90
- Misses 15961 16081 +120
- Partials 1950 1971 +21
|
@leizhiyuan Please fix the ci problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
请在上述md文件中登记pr信息和作者信息
Please register pr information and author information in the above md file
Error: Failures: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fiees #6772
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
test case
Ⅴ. Special notes for reviews