-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: merge the packaging processes of namingserver and seata-server #6819
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6819 +/- ##
=========================================
Coverage 52.42% 52.43%
Complexity 6380 6380
=========================================
Files 1080 1080
Lines 37558 37558
Branches 4452 4450 -2
=========================================
+ Hits 19689 19692 +3
+ Misses 15919 15917 -2
+ Partials 1950 1949 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -264,6 +264,8 @@ | |||
<include>**/*.def</include> | |||
</includes> | |||
<excludes> | |||
<exclude>**/script/**</exclude> | |||
<exclude>**/generated/**</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate with L269.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@funky-eyes Can the apache-seata folder be removed, or is there another purpose for it later on?
2.1.0: └── apache-seata-2.1.0-incubating-bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
目录结构
directory structure
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews