-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:[loom] replace the usages of synchronized with ReentrantLock #7073
base: 2.x
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7073 +/- ##
============================================
+ Coverage 52.58% 52.61% +0.02%
- Complexity 6681 6688 +7
============================================
Files 1131 1132 +1
Lines 40277 40297 +20
Branches 4723 4726 +3
============================================
+ Hits 21179 21201 +22
+ Misses 17072 17071 -1
+ Partials 2026 2025 -1
|
The files below saga are handled separately by another pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this class are the synchronized removal of methods and the addition of a try in the code (resourceLock ignored = Resourcelock.obtain ()).
There are more changes here because after adding try, the internal code format is indented
Ⅰ. Describe what this PR did
To use virtual threads in JDK 21, we need to remove the usage of synchronized to prevent the issue where "a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier."
There are two scenarios in which a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier:
When it executes code inside a synchronized block or method, or When it executes a native method or a foreign function.
Pinning does not make an application incorrect, but it might hinder its scalability. If a virtual thread performs a blocking operation such as I/O or BlockingQueue.take() while it is pinned, then its carrier and the underlying OS thread are blocked for the duration of the operation. Frequent pinning for long durations can harm the scalability of an application by capturing carriers.
The scheduler does not compensate for pinning by expanding its parallelism. Instead, avoid frequent and long-lived pinning by revising synchronized blocks or methods that run frequently and guard potentially long I/O operations to use java.util.concurrent.locks.ReentrantLock instead. There is no need to replace synchronized blocks and methods that are used infrequently (e.g., only performed at startup) or that guard in-memory operations. As always, strive to keep locking policies simple and clear.
You can refer to the following documents:
https://openjdk.org/jeps/444
https://openjdk.org/projects/loom/
Ⅱ. Does this pull request fix one issue?
fixes #6971
This pr does not include the saga module.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews