[#2278] feat(coordinator): Introduce AccessSupportRssChecker to reject the un-support application earlier #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
changed the title
maobaolong
force-pushed
the
supportRssChecker
branch
from
5eb22b9 to
3d2c4df
Compare
jerqi
reviewed
Dec 10, 2024
| @@ -92,7 +93,8 @@ public class CoordinatorConf extends RssBaseConf { | |||
| .asList() | |||
| .defaultValues( | |||
| "org.apache.uniffle.coordinator.access.checker.AccessClusterLoadChecker", | |||
| "org.apache.uniffle.coordinator.access.checker.AccessQuotaChecker") | |||
| "org.apache.uniffle.coordinator.access.checker.AccessQuotaChecker", | |||
| AccessSupportRssChecker.class.getCanonicalName()) | |||
There was a problem hiding this comment.
Could you modify the document, too.
jerqi
reviewed
Dec 10, 2024
| @@ -92,7 +93,8 @@ public class CoordinatorConf extends RssBaseConf { | |||
| .asList() | |||
| .defaultValues( | |||
| "org.apache.uniffle.coordinator.access.checker.AccessClusterLoadChecker", | |||
| "org.apache.uniffle.coordinator.access.checker.AccessQuotaChecker") | |||
| "org.apache.uniffle.coordinator.access.checker.AccessQuotaChecker", | |||
There was a problem hiding this comment.
Could you use similar way to refactor the code like AccessSupportRssChecker.class.getCanonicalName()?
jerqi
reviewed
Dec 10, 2024
|
|
||
| @Override | ||
| public AccessCheckResult check(AccessInfo accessInfo) { | ||
| String serializer = accessInfo.getExtraProperties().get("serializer"); |
There was a problem hiding this comment.
This is related to the Spark engine. How to make this more common?
There was a problem hiding this comment.
@jerqi Yeah, so how about add a new config to make this abstract? lets say it unsupportConfigs,
For example unsupportConfigs="serializer:org.apache.hadoop.io.serializer.JavaSerialization"
There was a problem hiding this comment.
We would better make that unsupportConfigs become configs for the shuffle server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce AccessSupportRssChecker to reject the un-support application earlier
Why are the changes needed?
Fix: #2278
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT