Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2300][Bug] Long tail tasks in the Write Stage retry phase results in data loss. #2301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yl09099
Copy link
Contributor

@yl09099 yl09099 commented Dec 19, 2024

What changes were proposed in this pull request?

The long-tail task in the previous Stage caused data loss, and this bug needs to be fixed.

Why are the changes needed?

Fix: #2300

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existential UT.

@yl09099 yl09099 changed the title [#2230][Bug] Long tail tasks in the Write Stage retry phase results in data loss. [#2300][Bug] Long tail tasks in the Write Stage retry phase results in data loss. Dec 19, 2024
@yl09099 yl09099 force-pushed the uniffle-2300 branch 2 times, most recently from 0c3ccff to de38df3 Compare December 19, 2024 09:15
Copy link

github-actions bot commented Dec 19, 2024

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 27m 1s ⏱️ - 6m 42s
 1 097 tests ±0   1 095 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 750 runs  ±0  13 720 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 355f691. ± Comparison against base commit 0481f21.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (44bfd0d) to head (355f691).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2301      +/-   ##
============================================
+ Coverage     52.27%   52.34%   +0.07%     
+ Complexity     3569     3362     -207     
============================================
  Files           543      513      -30     
  Lines         29797    27585    -2212     
  Branches       2779     2593     -186     
============================================
- Hits          15575    14439    -1136     
+ Misses        13227    12206    -1021     
+ Partials        995      940      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Long tail tasks in the Write Stage retry phase results in data loss.
2 participants