Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2308] improvement(server): More detailed and clear logs on reading failure for FileSegmentManagedBuffer #2309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zuston
Copy link
Member

@zuston zuston commented Dec 27, 2024

What changes were proposed in this pull request?

More detailed and clear logs on reading failure for FileSegmentManagedBuffer

Why are the changes needed?

for #2308

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

…ading failure for FileSegmentManagedBuffer
@zuston zuston requested a review from jerqi December 27, 2024 10:00
Copy link

github-actions bot commented Dec 27, 2024

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 26m 15s ⏱️ - 1m 11s
 1 097 tests ±0   1 095 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 750 runs  ±0  13 720 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 6af2828. ± Comparison against base commit 1c56e74.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants