Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[486] Add DISCLAIMER-WIP for first release #487

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

vinishjail97
Copy link
Contributor

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

Adding DISCLAIMER-WIP as per apache guide mentioned below.
https://incubator.apache.org/policy/incubation.html#disclaimers

This was decided based on the feedback given by the community in this dev mail thread.
https://lists.apache.org/thread/kjwtg55rdcllvyol6sqszd6ozgto7z45

Brief change log

(for example:)

  • Add DISCLAIMER-WIP

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

DISCLAIMER-WIP Outdated Show resolved Hide resolved
Copy link
Contributor

@jcamachor jcamachor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

DISCLAIMER-WIP Outdated Show resolved Hide resolved
@vinishjail97 vinishjail97 merged commit c9c4a52 into main Jul 11, 2024
2 checks passed
@vinishjail97 vinishjail97 deleted the 486-Disclaimers branch July 11, 2024 05:46
Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to consider. (unrelated to this PR, but in the same vein).

  1. Adding a doap file
    https://github.com/apache/hudi/blob/release-0.5.3/doap_HUDI.rdf or we can look at how recent incubatees do it.

  2. Do we need anything transitively listed out in the NOTICE like here https://github.com/apache/hudi/blob/release-0.5.2-incubating/NOTICE

@@ -0,0 +1,19 @@
Apache XTable (incubating) is an effort undergoing incubation at The Apache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems consistent with what we had for Hudi back then
https://github.com/apache/hudi/blob/release-0.5.2-incubating/DISCLAIMER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants