Simplify build by providing LIBCMARKDIR to script #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build-cmark.sh builds code in a temp dir and copies output to desired location, so there is no need to parse stdout from build-cmark.sh to find the library
|
+1 on the concept, and initial review looks good. |
jsoref
reviewed
Feb 5, 2025
pelican/action.yml
Outdated
| # ensure LIBCMARKDIR is defined for subsequent steps | ||
| echo "LIBCMARKDIR=${LIBCMARKDIR}" >> $GITHUB_ENV | ||
| # build the code and define LIBCMARKDIR under $WORKDIR | ||
| bash ${{ github.action_path }}/build-cmark.sh $GFM_VERSION $LIBCMARKDIR |
There was a problem hiding this comment.
There's a $GITHUB_ACTION_PATH which you should generally use (and you should never use ${{ ... }} inside a run: block)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-cmark.sh builds code in a temp dir and copies output to desired location, so there is no need to parse stdout from build-cmark.sh to find the library