Skip to content

Better hostname check #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better hostname check #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d53f6f
Better hostname check
sebbASF Sep 26, 2025
2d4faca
Fix Ruff complaint
sebbASF Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asfyaml/feature/github/branch_protection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def _run_paged_graphql_query(
variables = {"endCursor": end_cursor}
variables.update(input_variables)

headers, data = self.ghrepo._requester.graphql_query(query, variables)
_headers, data = self.ghrepo._requester.graphql_query(query, variables)
result = data["data"]["repository"]["refs"]["nodes"]

for rule in result:
Expand Down
2 changes: 1 addition & 1 deletion asfyaml/feature/website_publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def run(self):

# Get optional target hostname:
hostname = self.yaml.hostname if "hostname" in self.yaml else None
if hostname and "apache.org" in hostname:
if hostname and hostname.endswith(".apache.org"):
if mappings.WS_HOSTNAME_OVERRIDES.get(self.repository.name, "") != hostname:
raise Exception(
f".asf.yaml: Invalid hostname '{hostname}' - you cannot specify *.apache.org hostnames, they must be inferred!"
Expand Down
Loading