Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10866][SDK] Transform SQL support sign function #10868

Closed
wants to merge 0 commits into from

Conversation

Zkplo
Copy link
Contributor

@Zkplo Zkplo commented Aug 24, 2024

Fixes #10866

Motivation

Add one arithmetic function classe: SignFunction. Also, add the corresponding unit test codes.

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Sorry, something went wrong.

@Zkplo Zkplo requested a review from aloyszhang August 26, 2024 09:00
aloyszhang
aloyszhang previously approved these changes Aug 27, 2024
luchunliang
luchunliang previously approved these changes Aug 27, 2024
vernedeng
vernedeng previously approved these changes Aug 27, 2024
@aloyszhang
Copy link
Contributor

plz rebase the master to resolve the conflict

@luchunliang luchunliang dismissed stale reviews from vernedeng, aloyszhang, and themself via b1b96df August 27, 2024 08:07
@aloyszhang
Copy link
Contributor

image
I'm afraid there is something wrong when rebasing the master, please do it the right way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL support sign function
5 participants