Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10881][SDK] Transform SQL support concat_ws function #10992

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

MOONSakura0614
Copy link
Contributor

Fixes #10881

Motivation

Modifications

Add a function class: ConcatWsFunction and its unit test.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@aloyszhang aloyszhang changed the title [INLONG-10881][SDK] Transform SQL support Concat_ws function [INLONG-10881][SDK] Transform SQL support concat_ws function Sep 3, 2024
@luchunliang
Copy link
Contributor

please fix the conflicting file

@luchunliang
Copy link
Contributor

Please use independent UT class file to avoid UT conflicting file.

- add distinct UT to avoid conflict
- add description of concat_ws function
@MOONSakura0614
Copy link
Contributor Author

Please use independent UT class file to avoid UT conflicting file.

done and thank you for your suggestion~

@aloyszhang aloyszhang merged commit 14e6c18 into apache:master Sep 9, 2024
8 checks passed
MOONSakura0614 added a commit to MOONSakura0614/inlong that referenced this pull request Sep 21, 2024
PeterZh6 pushed a commit to PeterZh6/inlong that referenced this pull request Sep 23, 2024
wohainilaodou pushed a commit to wohainilaodou/inlong that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL support Concat_ws function
4 participants