Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table model insertion auto-cast & Fix TVList not removed when all data are deleted. #14391

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

jt2594838
Copy link
Contributor

Table model insertion can use auto-cast if the incoming data type is compatible with the registered type.
Below are the tolerant casts, the first column is the registered type, and the second column is the incoming type.
img_v3_02hf_cad6a09f-831d-4fa7-a7d0-176ebdc5aefg

@SteveYurongSu SteveYurongSu self-requested a review December 12, 2024 04:07
@jt2594838 jt2594838 changed the title Table model insertion auto-cast Table model insertion auto-cast & Fix TVList not removed when all data are deleted. Dec 12, 2024
# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 51.28205% with 19 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (4c21331) to head (9693149).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...he/iotdb/db/utils/datastructure/AlignedTVList.java 27.27% 8 Missing ⚠️
...lan/relational/sql/ast/WrappedInsertStatement.java 63.63% 4 Missing ⚠️
...engine/plan/statement/crud/InsertRowStatement.java 0.00% 2 Missing ⚠️
...ine/plan/statement/crud/InsertTabletStatement.java 0.00% 2 Missing ⚠️
...e/dataregion/memtable/AlignedWritableMemChunk.java 0.00% 2 Missing ⚠️
...aregion/memtable/AlignedWritableMemChunkGroup.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14391   +/-   ##
=========================================
  Coverage     39.65%   39.66%           
  Complexity      185      185           
=========================================
  Files          4327     4327           
  Lines        275060   275038   -22     
  Branches      33413    33399   -14     
=========================================
- Hits         109087   109084    -3     
+ Misses       165973   165954   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveYurongSu SteveYurongSu self-assigned this Dec 13, 2024
# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
@SteveYurongSu SteveYurongSu merged commit 72c803f into master Dec 18, 2024
36 of 37 checks passed
@SteveYurongSu SteveYurongSu deleted the table_model_auto_cast branch December 18, 2024 10:28
SteveYurongSu pushed a commit that referenced this pull request Dec 18, 2024
…easurement to be null and caused the memory estimator to throw NPE (#14391) (#14488)

Co-authored-by: Tian Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants