Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate table/tree model database & Added SchemaRegionGroupNum / dataRegionGroupNum in table databases details & Fixed the message and database semantic for table flush operation with database #14398

Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
df31a31
Update ClusterSchemaInfo.java
Caideyipi Dec 10, 2024
6a9f6a4
Add
Caideyipi Dec 10, 2024
f250f24
clear db
Caideyipi Dec 10, 2024
d6ce2a6
Details
Caideyipi Dec 10, 2024
f6099cf
partial
Caideyipi Dec 10, 2024
915b36e
cleaning
Caideyipi Dec 10, 2024
04dd985
revert
Caideyipi Dec 10, 2024
910322a
partial
Caideyipi Dec 10, 2024
22edbbb
refactor
Caideyipi Dec 12, 2024
52b241b
refactor
Caideyipi Dec 12, 2024
dcb1f28
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 12, 2024
891ae5d
Refactor
Caideyipi Dec 12, 2024
1d1cc32
fix
Caideyipi Dec 12, 2024
9796476
Fix
Caideyipi Dec 12, 2024
acfa62d
Update CreateTableTask.java
Caideyipi Dec 12, 2024
33ed4bb
Update ClusterSchemaInfo.java
Caideyipi Dec 12, 2024
e604737
partial
Caideyipi Dec 12, 2024
cc0d808
Fix
Caideyipi Dec 12, 2024
d30e422
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 12, 2024
7654d39
Fix
Caideyipi Dec 12, 2024
c4e71be
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 12, 2024
accfc34
Fix
Caideyipi Dec 12, 2024
56eff41
Fix
Caideyipi Dec 12, 2024
f27dd8d
Refactor
Caideyipi Dec 12, 2024
89a5409
Update PushPredicateIntoTableScan.java
Caideyipi Dec 12, 2024
33c38c4
fix
Caideyipi Dec 12, 2024
c116ec7
Update DataPartition.java
Caideyipi Dec 12, 2024
a41eaf7
Fix
Caideyipi Dec 12, 2024
e4a7de5
Fix
Caideyipi Dec 12, 2024
22eeafc
Update SchemaPartition.java
Caideyipi Dec 12, 2024
6cacf04
Delete database
Caideyipi Dec 12, 2024
bc0a3a3
Merge remote-tracking branch 'upstream/master' into separate-db
Caideyipi Dec 12, 2024
75ff3a5
Update IoTDBDatabaseIT.java
Caideyipi Dec 12, 2024
7489437
Fix
Caideyipi Dec 12, 2024
735d981
Fix
Caideyipi Dec 12, 2024
afcdad2
Update AbstractSchemaRegionTest.java
Caideyipi Dec 12, 2024
784edf2
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 12, 2024
c1a6162
Fix
Caideyipi Dec 12, 2024
c4757b9
Fix
Caideyipi Dec 12, 2024
1b468ba
Flush
Caideyipi Dec 12, 2024
5f35599
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 12, 2024
2193dd4
Update IoTDBSimpleQueryIT.java
Caideyipi Dec 12, 2024
f81708b
Update IoTDBDeleteStorageGroupIT.java
Caideyipi Dec 12, 2024
aea5c9e
Update ConfigManager.java
Caideyipi Dec 12, 2024
06e79b1
Fix
Caideyipi Dec 12, 2024
c672f0e
Test fix
Caideyipi Dec 13, 2024
2e5cac6
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 13, 2024
56b4536
Fix
Caideyipi Dec 13, 2024
7527ba1
Fix
Caideyipi Dec 13, 2024
7efd2aa
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 13, 2024
122c0ef
Update IoTDBDatabaseIT.java
Caideyipi Dec 13, 2024
77b816b
Merge remote-tracking branch 'upstream/master' into separate-db
Caideyipi Dec 13, 2024
9d9a28b
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 13, 2024
19e6ded
Update ClusterSchemaInfo.java
Caideyipi Dec 13, 2024
9504386
Update AnalyzerTest.java
Caideyipi Dec 13, 2024
534ea5e
Fixed
Caideyipi Dec 13, 2024
3a10168
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 13, 2024
ee59eae
Fix
Caideyipi Dec 13, 2024
3cc064c
Fix
Caideyipi Dec 13, 2024
910c099
Fix
Caideyipi Dec 13, 2024
2147969
Revert "Delete database"
Caideyipi Dec 13, 2024
3610d5b
Update ClusterSchemaInfo.java
Caideyipi Dec 13, 2024
d5ba147
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 13, 2024
01c51ea
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 16, 2024
c05a79e
Fix
Caideyipi Dec 16, 2024
81c5538
Fix
Caideyipi Dec 16, 2024
a32d998
Update PipeHistoricalDataRegionTsFileAndDeletionExtractor.java
Caideyipi Dec 16, 2024
475e3ea
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 16, 2024
77f5505
Update ClusterConfigTaskExecutor.java
Caideyipi Dec 16, 2024
abb2973
Merge remote-tracking branch 'upstream/master' into separate-db
Caideyipi Dec 16, 2024
a9b6a79
Update TableConfigTaskVisitor.java
Caideyipi Dec 17, 2024
c38e236
Bug fix
Caideyipi Dec 17, 2024
1206c46
Fix
Caideyipi Dec 17, 2024
c3da485
Update DataNodeSpaceQuotaManager.java
Caideyipi Dec 17, 2024
65b62e3
Fix
Caideyipi Dec 17, 2024
d288383
partial
Caideyipi Dec 17, 2024
48af0ad
Fix
Caideyipi Dec 17, 2024
3a5dbd8
Merge branch 'master' of https://github.com/apache/iotdb into separat…
Caideyipi Dec 17, 2024
e60ad30
may fix
Caideyipi Dec 17, 2024
23ed88f
Fix
Caideyipi Dec 17, 2024
bea025c
Fix
Caideyipi Dec 17, 2024
dbb4b70
Fix
Caideyipi Dec 17, 2024
0517a3b
Update ClusterPartitionFetcher.java
Caideyipi Dec 17, 2024
0724f70
Fix
Caideyipi Dec 17, 2024
10a62c3
Fix
Caideyipi Dec 17, 2024
1989202
Fix
Caideyipi Dec 17, 2024
26e0389
Update IPartitionFetcher.java
Caideyipi Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,6 @@ public void testStorageGroupWithHyphenInName() {
try (final ResultSet resultSet = statement.executeQuery("SHOW DATABASES DETAILS")) {
while (resultSet.next()) {
Assert.assertEquals("root.group_with_hyphen", resultSet.getString(1));
Assert.assertEquals("TREE", resultSet.getString(12));
}
}
} catch (final SQLException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ public void testDeleteMultipleStorageGroupWithQuote() throws Exception {

@Test(expected = SQLException.class)
public void deleteNonExistStorageGroup() throws Exception {
try (Connection connection = EnvFactory.getEnv().getConnection();
Statement statement = connection.createStatement()) {
try (final Connection connection = EnvFactory.getEnv().getConnection();
final Statement statement = connection.createStatement()) {
statement.execute("CREATE DATABASE root.ln2.wf01.wt01");
statement.execute("DELETE DATABASE root.ln2.wf01.wt02");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ public void testPipeAfterDataRegionLeaderStop() throws Exception {
}

final AtomicInteger leaderPort = new AtomicInteger(-1);
final TShowRegionResp showRegionResp = client.showRegion(new TShowRegionReq());
final TShowRegionResp showRegionResp =
client.showRegion(new TShowRegionReq().setIsTableModel(true));
showRegionResp
.getRegionInfoList()
.forEach(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,15 +181,15 @@ public void testFlushGivenGroupNoData() {
@Test
@Ignore
public void testFlushNotExistGroupNoData() {
try (Connection connection = EnvFactory.getEnv().getConnection();
Statement statement = connection.createStatement()) {
try (final Connection connection = EnvFactory.getEnv().getConnection();
final Statement statement = connection.createStatement()) {
statement.execute("CREATE DATABASE root.noexist.nodatagroup1");
try {
statement.execute(
"FLUSH root.noexist.nodatagroup1,root.notExistGroup1,root.notExistGroup2");
} catch (SQLException sqe) {
} catch (final SQLException sqe) {
String expectedMsg =
"322: 322: storageGroup root.notExistGroup1,root.notExistGroup2 does not exist";
"322: 322: Database root.notExistGroup1,root.notExistGroup2 does not exist";
sqe.printStackTrace();
assertTrue(sqe.getMessage().contains(expectedMsg));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ public void testManageDatabase() {
int[] schemaReplicaFactors = new int[] {1};
int[] dataReplicaFactors = new int[] {1};
int[] timePartitionInterval = new int[] {604800000};
String[] model = new String[] {"TABLE"};

// show
try (final ResultSet resultSet = statement.executeQuery("SHOW DATABASES")) {
Expand All @@ -106,6 +105,8 @@ public void testManageDatabase() {
assertEquals(databaseNames.length, cnt);
}

final int[] schemaRegionGroupNum = new int[] {0};
final int[] dataRegionGroupNum = new int[] {0};
// show
try (final ResultSet resultSet = statement.executeQuery("SHOW DATABASES DETAILS")) {
int cnt = 0;
Expand All @@ -121,7 +122,8 @@ public void testManageDatabase() {
assertEquals(schemaReplicaFactors[cnt], resultSet.getInt(3));
assertEquals(dataReplicaFactors[cnt], resultSet.getInt(4));
assertEquals(timePartitionInterval[cnt], resultSet.getLong(5));
assertEquals(model[cnt], resultSet.getString(6));
assertEquals(schemaRegionGroupNum[cnt], resultSet.getInt(6));
assertEquals(dataRegionGroupNum[cnt], resultSet.getInt(7));
cnt++;
}
assertEquals(databaseNames.length, cnt);
Expand Down Expand Up @@ -305,4 +307,49 @@ public void testDatabaseWithSpecificCharacters() throws SQLException {
Collections.singleton("1,4,"));
}
}

@Test
public void testMixedDatabase() throws SQLException {
try (final Connection connection =
EnvFactory.getEnv().getConnection(BaseEnv.TABLE_SQL_DIALECT);
final Statement statement = connection.createStatement()) {
statement.execute("create database test");
}

try (final Connection connection = EnvFactory.getEnv().getConnection();
final Statement statement = connection.createStatement()) {
statement.execute("create database root.test");
statement.execute(
"alter database root.test WITH SCHEMA_REGION_GROUP_NUM=2, DATA_REGION_GROUP_NUM=3");
statement.execute("drop database root.test");
}

try (final Connection connection =
EnvFactory.getEnv().getConnection(BaseEnv.TABLE_SQL_DIALECT);
final Statement statement = connection.createStatement()) {
try (final ResultSet resultSet = statement.executeQuery("SHOW DATABASES DETAILS")) {
assertTrue(resultSet.next());
assertEquals("test", resultSet.getString(1));
assertEquals(0, resultSet.getInt(6));
assertEquals(0, resultSet.getInt(7));
assertFalse(resultSet.next());
}
}

try (final Connection connection = EnvFactory.getEnv().getConnection();
final Statement statement = connection.createStatement()) {
statement.execute("create database root.test");
}

try (final Connection connection =
EnvFactory.getEnv().getConnection(BaseEnv.TABLE_SQL_DIALECT);
final Statement statement = connection.createStatement()) {
statement.execute("drop database test");
}

try (final Connection connection = EnvFactory.getEnv().getConnection();
final Statement statement = connection.createStatement()) {
TestUtils.assertResultSetSize(statement.executeQuery("show databases"), 1);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,27 @@ public class CountDatabasePlan extends ConfigPhysicalReadPlan {

private final String[] storageGroupPattern;
private final PathPatternTree scope;
private final boolean isTableModel;

public CountDatabasePlan(final List<String> storageGroupPattern, final PathPatternTree scope) {
public CountDatabasePlan(
final List<String> storageGroupPattern,
final PathPatternTree scope,
final boolean isTableModel) {
super(ConfigPhysicalPlanType.CountDatabase);
this.storageGroupPattern = storageGroupPattern.toArray(new String[0]);
this.scope = scope;
this.isTableModel = isTableModel;
}

public CountDatabasePlan(
final ConfigPhysicalPlanType type,
final List<String> storageGroupPattern,
final PathPatternTree scope) {
final PathPatternTree scope,
final boolean isTableModel) {
super(type);
this.storageGroupPattern = storageGroupPattern.toArray(new String[0]);
this.scope = scope;
this.isTableModel = isTableModel;
}

public String[] getDatabasePattern() {
Expand All @@ -54,6 +61,10 @@ public PathPatternTree getScope() {
return scope;
}

public boolean isTableModel() {
return isTableModel;
}

@Override
public boolean equals(final Object o) {
if (this == o) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@

public class GetDatabasePlan extends CountDatabasePlan {

public GetDatabasePlan(final List<String> storageGroupPathPattern, final PathPatternTree scope) {
super(ConfigPhysicalPlanType.GetDatabase, storageGroupPathPattern, scope);
public GetDatabasePlan(
final List<String> storageGroupPathPattern,
final PathPatternTree scope,
final boolean isTableModel) {
super(ConfigPhysicalPlanType.GetDatabase, storageGroupPathPattern, scope, isTableModel);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public AdjustMaxRegionGroupNumPlan() {
this.maxRegionGroupNumMap = new HashMap<>();
}

public void putEntry(String storageGroup, Pair<Integer, Integer> maxRegionGroupNum) {
public void putEntry(final String storageGroup, final Pair<Integer, Integer> maxRegionGroupNum) {
maxRegionGroupNumMap.put(storageGroup, maxRegionGroupNum);
}

Expand All @@ -51,11 +51,11 @@ public Map<String, Pair<Integer, Integer>> getMaxRegionGroupNumMap() {
}

@Override
protected void serializeImpl(DataOutputStream stream) throws IOException {
protected void serializeImpl(final DataOutputStream stream) throws IOException {
ReadWriteIOUtils.write(getType().getPlanType(), stream);

ReadWriteIOUtils.write(maxRegionGroupNumMap.size(), stream);
for (Map.Entry<String, Pair<Integer, Integer>> maxRegionGroupNumEntry :
for (final Map.Entry<String, Pair<Integer, Integer>> maxRegionGroupNumEntry :
maxRegionGroupNumMap.entrySet()) {
ReadWriteIOUtils.write(maxRegionGroupNumEntry.getKey(), stream);
ReadWriteIOUtils.write(maxRegionGroupNumEntry.getValue().getLeft(), stream);
Expand All @@ -64,27 +64,27 @@ protected void serializeImpl(DataOutputStream stream) throws IOException {
}

@Override
protected void deserializeImpl(ByteBuffer buffer) throws IOException {
int storageGroupNum = buffer.getInt();
protected void deserializeImpl(final ByteBuffer buffer) throws IOException {
final int storageGroupNum = buffer.getInt();

for (int i = 0; i < storageGroupNum; i++) {
String storageGroup = ReadWriteIOUtils.readString(buffer);
int maxSchemaRegionGroupNum = buffer.getInt();
int maxDataRegionGroupNum = buffer.getInt();
final String storageGroup = ReadWriteIOUtils.readString(buffer);
final int maxSchemaRegionGroupNum = buffer.getInt();
final int maxDataRegionGroupNum = buffer.getInt();
maxRegionGroupNumMap.put(
storageGroup, new Pair<>(maxSchemaRegionGroupNum, maxDataRegionGroupNum));
}
}

@Override
public boolean equals(Object o) {
public boolean equals(final Object o) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
AdjustMaxRegionGroupNumPlan that = (AdjustMaxRegionGroupNumPlan) o;
final AdjustMaxRegionGroupNumPlan that = (AdjustMaxRegionGroupNumPlan) o;
return maxRegionGroupNumMap.equals(that.maxRegionGroupNumMap);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public SetSpaceQuotaPlan() {
super(ConfigPhysicalPlanType.setSpaceQuota);
}

public SetSpaceQuotaPlan(List<String> prefixPathList, TSpaceQuota spaceLimit) {
public SetSpaceQuotaPlan(final List<String> prefixPathList, final TSpaceQuota spaceLimit) {
super(ConfigPhysicalPlanType.setSpaceQuota);
this.prefixPathList = prefixPathList;
this.spaceLimit = spaceLimit;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public CreateRegionGroupsPlan() {
this.regionGroupMap = new HashMap<>();
}

public CreateRegionGroupsPlan(ConfigPhysicalPlanType type) {
public CreateRegionGroupsPlan(final ConfigPhysicalPlanType type) {
super(type);
this.regionGroupMap = new HashMap<>();
}
Expand All @@ -59,16 +59,17 @@ public Map<String, List<TRegionReplicaSet>> getRegionGroupMap() {
return regionGroupMap;
}

public void addRegionGroup(String database, TRegionReplicaSet regionReplicaSet) {
public void addRegionGroup(final String database, final TRegionReplicaSet regionReplicaSet) {
regionGroupMap
.computeIfAbsent(database, regionReplicaSets -> new ArrayList<>())
.add(regionReplicaSet);
}

public void planLog(Logger logger) {
for (Map.Entry<String, List<TRegionReplicaSet>> regionGroupEntry : regionGroupMap.entrySet()) {
String database = regionGroupEntry.getKey();
for (TRegionReplicaSet regionReplicaSet : regionGroupEntry.getValue()) {
public void planLog(final Logger logger) {
for (final Map.Entry<String, List<TRegionReplicaSet>> regionGroupEntry :
regionGroupMap.entrySet()) {
final String database = regionGroupEntry.getKey();
for (final TRegionReplicaSet regionReplicaSet : regionGroupEntry.getValue()) {
logger.info(
"[CreateRegionGroups] RegionGroup: {}, belonged database: {}, on DataNodes: {}",
regionReplicaSet.getRegionId(),
Expand All @@ -80,24 +81,24 @@ public void planLog(Logger logger) {
}
}

public void serializeForProcedure(DataOutputStream stream) throws IOException {
public void serializeForProcedure(final DataOutputStream stream) throws IOException {
this.serializeImpl(stream);
}

public void deserializeForProcedure(ByteBuffer buffer) throws IOException {
public void deserializeForProcedure(final ByteBuffer buffer) throws IOException {
// to remove the planType of ConfigPhysicalPlanType
buffer.getShort();
this.deserializeImpl(buffer);
}

@Override
protected void serializeImpl(DataOutputStream stream) throws IOException {
protected void serializeImpl(final DataOutputStream stream) throws IOException {
stream.writeShort(getType().getPlanType());

stream.writeInt(regionGroupMap.size());
for (Entry<String, List<TRegionReplicaSet>> entry : regionGroupMap.entrySet()) {
String database = entry.getKey();
List<TRegionReplicaSet> regionReplicaSets = entry.getValue();
for (final Entry<String, List<TRegionReplicaSet>> entry : regionGroupMap.entrySet()) {
final String database = entry.getKey();
final List<TRegionReplicaSet> regionReplicaSets = entry.getValue();
BasicStructureSerDeUtil.write(database, stream);
stream.writeInt(regionReplicaSets.size());
regionReplicaSets.forEach(
Expand All @@ -107,23 +108,23 @@ protected void serializeImpl(DataOutputStream stream) throws IOException {
}

@Override
protected void deserializeImpl(ByteBuffer buffer) throws IOException {
int databaseNum = buffer.getInt();
protected void deserializeImpl(final ByteBuffer buffer) throws IOException {
final int databaseNum = buffer.getInt();
for (int i = 0; i < databaseNum; i++) {
String database = BasicStructureSerDeUtil.readString(buffer);
final String database = BasicStructureSerDeUtil.readString(buffer);
regionGroupMap.put(database, new ArrayList<>());

int regionReplicaSetNum = buffer.getInt();
final int regionReplicaSetNum = buffer.getInt();
for (int j = 0; j < regionReplicaSetNum; j++) {
TRegionReplicaSet regionReplicaSet =
final TRegionReplicaSet regionReplicaSet =
ThriftCommonsSerDeUtils.deserializeTRegionReplicaSet(buffer);
regionGroupMap.get(database).add(regionReplicaSet);
}
}
}

@Override
public boolean equals(Object o) {
public boolean equals(final Object o) {
if (this == o) {
return true;
}
Expand All @@ -133,7 +134,7 @@ public boolean equals(Object o) {
if (!super.equals(o)) {
return false;
}
CreateRegionGroupsPlan that = (CreateRegionGroupsPlan) o;
final CreateRegionGroupsPlan that = (CreateRegionGroupsPlan) o;
return Objects.equals(regionGroupMap, that.regionGroupMap);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class NoAvailableRegionGroupException extends ConfigNodeException {
private static final String SCHEMA_REGION_GROUP = "SchemaRegionGroup";
private static final String DATA_REGION_GROUP = "DataRegionGroup";

public NoAvailableRegionGroupException(TConsensusGroupType regionGroupType) {
public NoAvailableRegionGroupException(final TConsensusGroupType regionGroupType) {
super(
String.format(
"There are no available %s RegionGroups currently, "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,20 @@ public ClusterQuotaManager(IManager configManager, QuotaInfo quotaInfo) {
regionDisk = new ConcurrentHashMap<>();
}

public TSStatus setSpaceQuota(TSetSpaceQuotaReq req) {
public TSStatus setSpaceQuota(final TSetSpaceQuotaReq req) {
if (!checkSpaceQuota(req)) {
return RpcUtils.getStatus(
TSStatusCode.EXECUTE_STATEMENT_ERROR.getStatusCode(),
"The used quota exceeds the preset quota. Please set a larger value.");
}
// TODO: Datanode failed to receive rpc
try {
TSStatus response =
final TSStatus response =
configManager
.getConsensusManager()
.write(new SetSpaceQuotaPlan(req.getDatabase(), req.getSpaceLimit()));
if (response.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
Map<Integer, TDataNodeLocation> dataNodeLocationMap =
final Map<Integer, TDataNodeLocation> dataNodeLocationMap =
configManager.getNodeManager().getRegisteredDataNodeLocations();
DataNodeAsyncRequestContext<TSetSpaceQuotaReq, TSStatus> clientHandler =
new DataNodeAsyncRequestContext<>(
Expand All @@ -95,7 +95,7 @@ public TSStatus setSpaceQuota(TSetSpaceQuotaReq req) {
return RpcUtils.squashResponseStatusList(clientHandler.getResponseList());
}
return response;
} catch (ConsensusException e) {
} catch (final ConsensusException e) {
LOGGER.warn(
String.format(
"Unexpected error happened while setting space quota on database: %s ",
Expand Down
Loading
Loading