-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TsfileSize column to 'show regions' #14436
base: master
Are you sure you want to change the base?
Add TsfileSize column to 'show regions' #14436
Conversation
liyuheng55555
commented
Dec 16, 2024
} | ||
builder | ||
.getColumnBuilder(12) | ||
.writeBinary(new Binary(regionSizeStr, TSFileConfig.STRING_CHARSET)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whether can use BytesUtils.valueOf() ? change string to byte
@@ -161,6 +161,7 @@ private ColumnHeaderConstant() { | |||
public static final String START_TIME = "StartTime"; | |||
public static final String ROLE = "Role"; | |||
public static final String CREATE_TIME = "CreateTime"; | |||
public static final String TSFILE_SIZE = "TsfileSize"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TsFileSize
for (Map<String, Pair<Long, Gauge>> map : unseqFileSizeMap.values()) { | ||
for (Map.Entry<String, Pair<Long, Gauge>> regionSizeEntry : map.entrySet()) { | ||
Integer regionId = Integer.parseInt(regionSizeEntry.getKey()); | ||
if (regionSizeMap.containsKey(regionId)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use compute API