Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ratis byte limit configuration too small #14449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OneSizeFitsQuorum
Copy link
Contributor

The current default speed limit for Ratis writes is 16MB, which is the same size as the bytebuffer, which is unreasonable. We should make it ten times bigger

Signed-off-by: OneSizeFitQuorum <[email protected]>
Copy link

sonarcloud bot commented Dec 16, 2024

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.64%. Comparing base (fbd1793) to head (1237de3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14449      +/-   ##
============================================
+ Coverage     39.62%   39.64%   +0.01%     
  Complexity      185      185              
============================================
  Files          4331     4331              
  Lines        275499   275499              
  Branches      33483    33483              
============================================
+ Hits         109174   109217      +43     
+ Misses       166325   166282      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant