OAK-11266: review changes

apache · Dec 11, 2024 · 426f5fb · 426f5fb
1 parent f0a5039
commit 426f5fb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/RemoteStorageMode.java b/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/RemoteStorageMode.java
diff --git a/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java b/oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java
@@ -495,12 +495,12 @@ public void setProperties(Properties properties) {
 
     private void setRemoteStorageMode() {
         String s3EndPoint = properties.getProperty(S3Constants.S3_END_POINT, "");
-        if (s3EndPoint.contains("https://storage.googleapis.com")) {
-            properties.putIfAbsent(S3Constants.MODE, RemoteStorageMode.GCP);
+        if (s3EndPoint.contains("googleapis")) {
+            properties.put(S3Constants.MODE, RemoteStorageMode.GCP);
             return;
         }
         // default mode is S3
-        properties.putIfAbsent(S3Constants.MODE, RemoteStorageMode.S3);
+        properties.put(S3Constants.MODE, RemoteStorageMode.S3);
     }
 
     @Override
@@ -1361,4 +1361,12 @@ public KeyRenameThread(String oldKey) {
             this.oldKey = oldKey;
         }
     }
+
+    /**
+     * Enum to indicate remote storage mode
+     */
+    private enum RemoteStorageMode {
+        S3,
+        GCP
+    }
 }