OAK-11199 getSubject is supported only if a security manager is allowed

[mbaedke]

No description provided.

[github-actions]

Commit-Check ❌

Commit rejected by Commit-Check.                                  
                                                                  
  (c).-.(c)    (c).-.(c)    (c).-.(c)    (c).-.(c)    (c).-.(c)  
   / ._. \      / ._. \      / ._. \      / ._. \      / ._. \   
 __\( C )/__  __\( H )/__  __\( E )/__  __\( C )/__  __\( K )/__ 
(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)
   || E ||      || R ||      || R ||      || O ||      || R ||   
 _.' '-' '._  _.' '-' '._  _.' '-' '._  _.' '-' '._  _.' '-' '._ 
(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)
 `-´     `-´  `-´     `-´  `-´     `-´  `-´     `-´  `-´     `-´ 
                                                                  
Commit rejected.                                                  
                                                                  
Type message check failed => OAK-11199: Java 23: getSubject is supported only if a security manager is allowed

Changed class name, added tests.
 
It doesn't match regex: ^OAK-\d+\s\S+.*
The commit message must start with 'OAK-<ID> ' followed by some descriptive text
Suggest: Please check your commit message whether it matches above regex

[reschke]

a) Compatibility
b) The new package in commons would need a package-info

Otherwise, looks good.

[reschke]

Recommendation:

• new package commons.jdkcompat (non-public, "internal" in package-info), export in pom.xml
• name of util class more specific, like Java23Security

[reschke]

The changes in commons now look good.

The other parts of the PR are minimal, which is good.

I haven't tested, I assume you did, @mbaedke

The one thing that came to mind is that if we change Java23Security to "Subject", changes would be even less intrusive. Or even "Java23Subject"? (this is bikeshedding, ignore if you want to)

[reschke]

And maybe we should deal with

https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1891&metric=new_coverage&view=list

[mbaedke]

I like Java23Subject. I wouldn't call it Subject at least for the reason that the method signatures are slightly different, which might confuse readers. Of course I tested, but will run integration tests again and look into the coverage issue before merging.

[sonarqubecloud]

Quality Gate failed

Failed conditions
22.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud