OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-jain
requested changes
Mar 10, 2025
| if (item instanceof CloudBlob) { | ||
| items.add(AzureBlobInfo.fromCloudBlob((CloudBlob)item)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this needed? Can't we just return the blobItems.getIterator()? Pagination based on max results is already handled by the sdk, https://learn.microsoft.com/en-us/azure/developer/java/sdk/pagination
There was a problem hiding this comment.
Consider just using the sdk without any decorator as well. Just returning blobItems.getIterator() directly in the getAll* methods
| */ | ||
| package org.apache.jackrabbit.oak.blob.cloud.azure.blobstorage; | ||
|
|
||
| public interface Constants { |
| @@ -94,12 +97,22 @@ public DataStore createDataStore() { | |||
|
|
|||
| String connectionString = Utils.getConnectionStringFromProperties(azProps); | |||
| try { | |||
| CloudBlobContainer container = Utils.getBlobContainer(connectionString, containerName); | |||
| container.createIfNotExists(); | |||
| boolean useSDK12 = Boolean.parseBoolean(azProps.getProperty(AZURE_SDK_12_ENABLED, "false")); | |||
There was a problem hiding this comment.
What about tests/implementations dependent upon the AzureDataStoreFixture, we should have parametrized tests or some other mechanism that test those with both v12 & v8 versions.
There are many command supproted in oak run utility which would have corresponding tests which should support above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.