OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated #2157
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joscorbe
approved these changes
Mar 12, 2025
Joscorbe
reviewed
Mar 12, 2025
| @@ -201,7 +201,7 @@ public void fullGC() { | |||
| assertTrue(output.contains("FullGcDelayFactory is : 2.0")); | |||
| assertTrue(output.contains("FullGcBatchSize is : 1000")); | |||
| assertTrue(output.contains("FullGcProgressSize is : 10000")); | |||
| assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400")); | |||
| assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n")); | |||
There was a problem hiding this comment.
I assume the \n is to ensure the value is exactly 86400 and not something else containing that string, but I wonder if we should then apply the same to the rest of asserts to maintain consistency.
There was a problem hiding this comment.
yes, the wrong value was 86400000 and was still passing the test
i've updated the same for all numeric values checks
rishabhdaim
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed conversion where default value is converted to millis not seconds