OAK-11594 - Converting existing indexes from a type to another leaves the async lane the same #2173
Conversation
chibulcuteanu
force-pushed
the
OAK-11594
branch
2 times, most recently
from
238123c to
5438a19
Compare
… the async lane the same
chibulcuteanu
force-pushed
the
OAK-11594
branch
from
c7302c9 to
caad7b6
Compare
| String idxBuilderType = idxBuilder.getString(TYPE_PROPERTY_NAME); | ||
|
|
||
| // check if provided index definitions is of different type than existing one | ||
| if (idxBuilderType != null && |
There was a problem hiding this comment.
Can be replaced with StringUtils.equals()
| LOG.info("Provided index [{}] has a different type compared to the existing index." + | ||
| " Using lane from the index definition provided", indexInfo.indexPath); |
There was a problem hiding this comment.
I would improve this message:
| LOG.info("Provided index [{}] has a different type compared to the existing index." + | |
| " Using lane from the index definition provided", indexInfo.indexPath); | |
| LOG.info("Provided index [{}] has a different type [{}] compared to the existing index [{}]." + | |
| " Using lane from the index definition provided", indexInfo.indexPath, indexInfo.type, idxBuilderType); |
| List<String> asyncLaneList = indexInfo.type.equals(TYPE_ELASTICSEARCH) ? | ||
| List.of(indexInfo.asyncLaneName) : List.of(indexInfo.asyncLaneName, INDEXING_MODE_NRT); |
There was a problem hiding this comment.
I don't think this is always correct. When the provided index is not of type elasticsearch, we are always adding nrt. This is wrong when we would convert an elasticsearch to lucene that does not need to be nrt.
As an example, try to change the unit test at line 173 with
builder.child("idx-a").setProperty("async", asList("async"), Type.STRINGS);
I would expect the async-previous at line 188 to be async and not async, nrt.
I think that when the index types differ, we should always use List.of(indexInfo.asyncLaneName). If we want to make sure that this logic is executed only when there is a conversion from lucene to elastic or viceversa, we can check that at least one of the types (provided or existing) is elasticsearch and completely skip this logic.
OAK-11594 - Converting existing indexes from a type to another leaves the async lane the same