MINOR: testDelayedTxnOffsetCommitWithBumpedEpochIsRejected #20024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dongnuo123
changed the title
chia7712
reviewed
Jun 26, 2025
| // Join the consumer group. Note that we don't heartbeat here so we must use | ||
| // a session long enough for the duration of the test. | ||
| val (memberId: String, memberEpoch: Int) = joinConsumerGroup(groupId, useNewProtocol) | ||
| assertTrue(memberId != JoinGroupRequest.UNKNOWN_MEMBER_ID) |
There was a problem hiding this comment.
assertNotEquals(JoinGroupRequest.UNKNOWN_MEMBER_ID, memberId)
assertNotEquals(JoinGroupRequest.UNKNOWN_GENERATION_ID, memberEpoch)assertNotEquals could show more readable messages.
| createTopic(topic, 1) | ||
|
|
||
| for (version <- ApiKeys.TXN_OFFSET_COMMIT.oldestVersion to ApiKeys.TXN_OFFSET_COMMIT.latestVersion(isUnstableApiEnabled)) { | ||
| val useTV2 = version >= 5 |
There was a problem hiding this comment.
how about using EndTxnRequest.LAST_STABLE_VERSION_BEFORE_TRANSACTION_V2 instead of magic number 5?
| @@ -51,6 +51,16 @@ class TxnOffsetCommitRequestTest(cluster:ClusterInstance) extends GroupCoordinat | |||
| testTxnOffsetCommit(false) | |||
| } | |||
|
|
|||
| @ClusterTest | |||
| def testDelayedTxnOffsetCommitWithBumpedEpochIsRejectedWithOldConsumerGroupProtocol(): Unit = { | |||
| testDelayedTxnOffsetCommitWithBumpedEpochIsRejected(true) | |||
There was a problem hiding this comment.
According to the naming, it should pass false instead of true, shouldn't it?
| expectedError = Errors.NONE | ||
| ) | ||
|
|
||
| // Start a new transaction. Wait for the previous transaction to complete. |
There was a problem hiding this comment.
Should we complete this new transaction? otherwise, the next version will have a ongoing transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an API level integration test for the producer epoch verification when processing transactional offset commit.